[Webkit-unassigned] [Bug 179020] [Touch Bar Web API] Add support for menuitem tag

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=179020

--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 325362
  --> https://bugs.webkit.org/attachment.cgi?id=325362
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325362&action=review

> Source/WebCore/ChangeLog:7
> +

I think it should be possible to write a simple test for this. I'll look for one to mimic.

> Source/WebCore/JSHTMLMenuitemElement.h:1
> +/*

This doesn't seem right. The generated file shouldn't be in the WebKit source tree, it should get generated into the build directory (and not show up in your patch). You may need help getting Xcode to do the right thing, it's not exactly straightforward.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171030/b8ff0ce9/attachment.html>