[Webkit-unassigned] [Bug 178896] [WPE] Can't run dyz

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=178896

--- Comment #14 from Carlos Alberto Lopez Perez <clopez at igalia.com> ---
(In reply to Michael Catanzaro from comment #12)
> $ INTEL_DEBUG=dri,fbo run-minibrowser --wpe --debug
> Starting dyz 
> xkbcommon: ERROR: couldn't find a Compose file for locale "C"
> INFO: GBM device is /dev/dri/renderD128� and GBM backend is drm
> PlatformDisplayWPE: could not create the EGL display.
> GLib-GIO-Message: Using the 'memory' GSettings backend.  Your settings will
> not be saved or shared with other applications.
> 
> Note that's U+FFFD 'Replacement Character' that I see on my terminal in the
> device name, which doesn't seem right.

That's likely a bug on my patch, as it seems readlink() doesn't add \0 to the end of the string by default and I didn't initialized it before. So that character is perhaps random garbage from the memory.

I think this should fix that:

-    char deviceName[PATH_MAX];
+    char deviceName[PATH_MAX] = {};


Can you test this? if this is right we may have a similar issue in GLibUtilities.cpp

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171030/c22d9c5b/attachment-0001.html>