[Webkit-unassigned] [Bug 178927] WebDriver process should not link to JavaScriptCore

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Oct 29 10:18:06 PDT 2017


--- Comment #3 from Brian Burg <bburg at apple.com> ---
Hey Carlos, here's some more information to help you out. The previous patch series moved stuff into the top-level JSON namespace, so classes were JSON::{Array, Object, Value}. If this goes into WTF then we can keep that, or make these WTF::JSON{Array, Object, Value}. Let me know what you think; if it is a general-purpose JSON class with tests than I think either name is acceptable.

The first patch:


Joe wrote out some reasonable test cases that you can cover for now:


Once that patch lands (to change all callsites to use the non-Inspector namespace) the rest is moving the implementation and changing header includes:


When all the code is moved into the new place then there are some great cleanups I'd like to pursue. The first is already posted here, but don't worry about fixing it up:


You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171029/a2d593a0/attachment.html>

More information about the webkit-unassigned mailing list