[Webkit-unassigned] [Bug 178160] [GStreamer][MSE] Trim space between codecs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=178160

Xabier Rodríguez Calvar <calvaris at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #325016|review?, commit-queue?      |review+, commit-queue+
              Flags|                            |

--- Comment #25 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 325016
  --> https://bugs.webkit.org/attachment.cgi?id=325016
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325016&action=review

> Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:845
> +        codec = codec.substring(slashIndex+1);

slashIndex + 1

> Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:850
> +        bool codecMatchesPattern = !fnmatch(pattern.string().utf8().data(), codec.utf8().data(), 0);
> +        if (codecMatchesPattern)
> +            return true;

You don't need the variable, just if to the fnmatch and return true.

Btw, the name of the variable should be doesCodecMatchPattern according to https://webkit.org/code-style-guidelines/#names

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171027/558b8d7d/attachment.html>