[Webkit-unassigned] [Bug 176894] [WinCairo] Add WTF files for wincairo webkit

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=176894

Yousuke Kimoto <Yousuke.Kimoto at sony.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #325022|0                           |1
        is obsolete|                            |
 Attachment #325106|                            |review?
              Flags|                            |

--- Comment #19 from Yousuke Kimoto <Yousuke.Kimoto at sony.com> ---
Created attachment 325106

  --> https://bugs.webkit.org/attachment.cgi?id=325106&action=review

[PATCH] Add WTF files for WinCairo WebKit

(In reply to Alex Christensen from comment #18)
> Comment on attachment 325022 [details]
> [PATCH] Add WTF files for WinCairo WebKit
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=325022&action=review
> 
> > Source/WTF/wtf/win/WorkItemContext.h:49
> > +    HANDLE* waitHandlePtr() { return &m_waitHandle.m_handle; }
> 
> This is unnecessary.

I deleted this line and used a direct reference to the address.

> > Source/WTF/wtf/win/WorkItemContext.h:56
> > +    Win32Handle m_handle = { };
> 
> These default constructors are unnecessary.  If we needed them, the = would
> be unnecessary.
>
> > Source/WTF/wtf/win/WorkQueueWin.cpp:57
> > +    {
> 
> This scope is unnecessary.

Those unnecessary lines were deleted.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171027/8768e16e/attachment.html>