[Webkit-unassigned] [Bug 175275] [Win] Detect Visual Studio 2017 location

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 26 20:02:46 PDT 2017


https://bugs.webkit.org/show_bug.cgi?id=175275

Stephan Szabo <stephan.szabo at sony.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #324032|0                           |1
        is obsolete|                            |
 Attachment #324032|review?                     |
              Flags|                            |
 Attachment #325068|0                           |1
        is obsolete|                            |

--- Comment #20 from Stephan Szabo <stephan.szabo at sony.com> ---
Created attachment 325105

  --> https://bugs.webkit.org/attachment.cgi?id=325105&action=review

Use vswhere to determine visual studio location

After discussion, add the 2017 fallbacks to the original patch version.

While testing noticed that if you had VSINSTALLDIR set to a 2015 version, you'd still potentially get a 2017 msbuild location and version if vswhere found that (while leaving the install dir pointing to 2015). Similarly, if you had it pointed to a 2017 install and did not have vswhere available, you'd get version 14 because it didn't handle the directory format. This version tries to make it consistent when using VSINSTALLDIR from the environment.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171027/846390e2/attachment-0001.html>


More information about the webkit-unassigned mailing list