[Webkit-unassigned] [Bug 178625] REGRESSION(r222090): [HarfBuzz] Arabic shaping is broken except for first word in line

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=178625

--- Comment #8 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Michael Catanzaro from comment #7)
> Comment on attachment 324979 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=324979&action=review
> 
> > Source/WebCore/platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.cpp:153
> > +        // FIXME: cover all other cases mentioned in the spec (ie. brackets or quotation marks).
> > +        // https://bugs.webkit.org/show_bug.cgi?id=177003.
> 
> This is probably important.

Not that much, this fixes edge cases like for example 

text [text with different script] more text

same applies for << >> and { }. It can happen that because of inherit or common, we end up using a different font for the open and close brackets. I would need a test case to fix this, though.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171026/6ccd721c/attachment.html>