[Webkit-unassigned] [Bug 178160] [GStreamer][MSE] Trim space between codecs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=178160

Xabier Rodríguez Calvar <calvaris at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #324667|review?, commit-queue?      |review-
              Flags|                            |

--- Comment #20 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 324667
  --> https://bugs.webkit.org/attachment.cgi?id=324667
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324667&action=review

Even when I did an r+ to the original patch, I think Charlie is right and you didn't address his comments in this patch. Maybe I misunderstood him but I just gave some guidance of how I think it shold be done.

> Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp:602
> +        if (!MediaPlayerPrivateGStreamerMSE::supportsCodecs({ originalMediaType })) {

If you keep the original signature + the overload, you don't need this.

> Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp:635
> +        if (!MediaPlayerPrivateGStreamerMSE::supportsCodecs({ structureName })) {

Ditto.

> Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:844
> +    for (String codec : codecs) {
> +        // Codecs might have whitespace around, e.g. when the string "vp8, vorbis" is split.
> +        codec = codec.stripWhiteSpace();

I think this won't be needed if you take const ContentType& here because that logic seems to be in that class.

> Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.h:86
> -    static bool supportsCodecs(const String& codecs);
> +    static bool supportsCodecs(const Vector<String>& codecs);

I think this function signature should left unchanged and create an overloaded that takes a const ContentType&. The original function should create the ContentType from a String and pass it to the overloaded function.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171026/319f3853/attachment.html>