[Webkit-unassigned] [Bug 178836] New: DidMoveToNewDocumentAssertionScope shouldn't be necessary

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 25 15:49:32 PDT 2017


https://bugs.webkit.org/show_bug.cgi?id=178836

            Bug ID: 178836
           Summary: DidMoveToNewDocumentAssertionScope shouldn't be
                    necessary
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: HTML DOM
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: rniwa at webkit.org
                CC: cdumez at apple.com

DidMoveToNewDocumentAssertionScope is there to only ensure Node::didMoveToNewDocument
is eventually called by implementations in derived classes.

A better to way to ensure that Node::didMoveToNewDocument is always called is to simply call it directly.
Since only subclasses of Element and ShadowRoot override this virtual member function
and we already have a special case for ShadowRoot, we can de-vritualize for all non-Element cases.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171025/c23d1d13/attachment.html>


More information about the webkit-unassigned mailing list