[Webkit-unassigned] [Bug 177279] [Win][JSCOnly] Make jsconly build testapi and dlls and copy dlls when running tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=177279

--- Comment #7 from Yusuke Suzuki <utatane.tea at gmail.com> ---
(In reply to Stephan Szabo from comment #5)
> Right now shell/DLLLauncherMain.cpp checks for WIN_CAIRO in places to
> separate it from applewin, for example 
> https://github.com/WebKit/webkit/blob/master/Source/JavaScriptCore/shell/
> DLLLauncherMain.cpp#L125
> where the library path added differs. And we're currently really only
> handling the wincairo paths in jsc-only, but that might change.
> 
> That file's related to the tiny launcher app mentioned in the below.
>
> I'm not sure of the history, but the shell, testapi, etc on Windows
> (non-jsc-only) build a separate <something>Lib.dll and then a small launcher
> to run the code from the dll. The description from when the launcher seemed
> to be added seemed like it was related to getting the apple support
> libraries for the testapi and similar apps.

OK, if there is no reason for this, I believe Windows difference should be removed. But it's ok for now.
Could you add FIXME to clean up these things if there is no reason to make Win build results separated from others?
Adding the FIXME comment to PlatformJSCOnly.cmake is preferable.

# FIXME: https://bugs.webkit.org/url-to-newly-filed-bug
# description...

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171024/930747ee/attachment-0001.html>