[Webkit-unassigned] [Bug 178160] [GStreamer][MSE] Trim space between codecs

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 24 03:08:48 PDT 2017


https://bugs.webkit.org/show_bug.cgi?id=178160

--- Comment #18 from Alicia Boya GarcĂ­a <aboya at igalia.com> ---
Comment on attachment 324558
  --> https://bugs.webkit.org/attachment.cgi?id=324558
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324558&action=review

>> Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:847
>> +        codec = codec.stripWhiteSpace();
> 
> I don't think we should be duplicating this logic, isn't the ContentType class in WebKit designed to handle this for us? See ContentType::parameter.

Good point: this function could receive a Vector<String> coming from ContentType::codecs() instead of parsing that parameter itself. I'll update the patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171024/01fc6738/attachment.html>


More information about the webkit-unassigned mailing list