[Webkit-unassigned] [Bug 178720] [GTK][WPE] Switch to use API::NavigationClient

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=178720

--- Comment #1 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Created attachment 324664

  --> https://bugs.webkit.org/attachment.cgi?id=324664&action=review

WIP

I've started to work on this, but I need some more feedback to finish it:

 - API::NavigationClient::decidePolicyForNavigationAction() is now used for both decidePolicyForNavigationAction and decidePolicyForNewWindowAction, but it doesn't provide the frame name. Is there any other way to get it?

 - Why API::Navigationclient::decidePolicyForNavigationResponse() receives a non-const NavigationResponse reference? Shouldn't it receive a Ref<NavigationResponse>&& instead?

 - WebPageProxy::decidePolicyForNewWindowAction() creates the API::NavigationAction using the request URL as original URL this way WTFMove(request), request.url(). I think this is using request after the move.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171024/90cc2c68/attachment-0001.html>