[Webkit-unassigned] [Bug 178651] New: Call FrameView::scheduleSelectionUpdate when selection needs repainting after layout instead of setting the RenderView dirty.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=178651

            Bug ID: 178651
           Summary: Call FrameView::scheduleSelectionUpdate when selection
                    needs repainting after layout instead of setting the
                    RenderView dirty.
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Layout and Rendering
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: zalan at apple.com
                CC: bfulgham at webkit.org, simon.fraser at apple.com,
                    zalan at apple.com

In https://trac.webkit.org/r167845 (bug 132172), the renderView->setNeedsLayout() call was introduced to trigger selection update.
However this is problematic in a couple of different ways.
1. marking the root renderer dirty does not trigger layout (this is very specific to the root, other renderers do trigger layout) -so this works as long as someone else schedules a layout.
2. when a subtree layout is already scheduled and we mark the root renderer dirty, the root gets stuck with the dirty flag (since the entry point for the subsequent layout is a descendant of the root and not the root itself). -this got revealed with bug 178621.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171023/178c668e/attachment.html>