[Webkit-unassigned] [Bug 178610] Update perf dashboard upload logic to support uploading binaries from owned commits.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 20 21:36:59 PDT 2017


https://bugs.webkit.org/show_bug.cgi?id=178610

--- Comment #3 from dewei_zhu at apple.com ---
Comment on attachment 324470
  --> https://bugs.webkit.org/attachment.cgi?id=324470
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324470&action=review

>> Websites/perf.webkit.org/public/api/upload-root.php:94
>> +            exit_with_error('InvalidRepository', array('repositoryName' => $repository_name, 'commitSet' => $commit_set_id, 'full' => $commit_repository_rows_in_set, 'dict' => $commit_by_owned_and_owner_repository_names));
> 
> Names like "full" and "dict" are too generic.
> I really don't think we should be dumping these entries.
> These error messages aren't meant to debug perf dashboard, it's for people writing scripts to submit roots.

You are right. I forgot to remove this debug info.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171021/81dceb58/attachment.html>


More information about the webkit-unassigned mailing list