[Webkit-unassigned] [Bug 178584] Support ::before/::after pseudo elements with display:contents

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=178584

Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #324426|review?                     |review+
              Flags|                            |

--- Comment #9 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 324426
  --> https://bugs.webkit.org/attachment.cgi?id=324426
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324426&action=review

> Source/WebCore/style/RenderTreeUpdaterGeneratedContent.cpp:117
> +            removeAndDestroyContentRenderers(*pseudoElement);
> +

Could you clarify why this code change is needed in the change log?

> Source/WebCore/style/RenderTreeUpdaterGeneratedContent.cpp:156
> +        if (pseudoElementRenderer)
> +            renderTreePosition.moveToLastChild();
> +        else
> +            renderTreePosition.computeNextSibling(*pseudoElement);

Could you also describe why code to move to the next sibling is needed in the change log?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171020/c901d13f/attachment.html>