[Webkit-unassigned] [Bug 178544] New: -Wsign-compare triggered by MallocBench

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=178544

            Bug ID: 178544
           Summary: -Wsign-compare triggered by MallocBench
           Product: WebKit
           Version: Other
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: mcatanzaro at igalia.com
                CC: lforschler at apple.com, utatane.tea at gmail.com

I see a warning now that MallocBench is enabled for Linux:

In file included from ../../PerformanceTests/MallocBench/MallocBench/Interpreter.cpp:28:0:
../../PerformanceTests/MallocBench/MallocBench/Interpreter.cpp: In constructor ‘Interpreter::Interpreter(const char*, bool, bool)’:
../../PerformanceTests/MallocBench/MallocBench/Interpreter.cpp:64:35: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
     assert(m_opCount * sizeof(Op) == buf.st_size);
            ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~

buf.st_size is an off_t, which is signed, so I think we should do static_cast<size_t>(buf.st_size).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171019/f1eb654b/attachment.html>