[Webkit-unassigned] [Bug 178543] REGRESSION(r223691): DFGByteCodeParser.cpp:1483:83: warning: comparison is always false due to limited range of data type [-Wtype-limits]

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=178543

Saam Barati <sbarati at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sbarati at apple.com

--- Comment #1 from Saam Barati <sbarati at apple.com> ---
(In reply to Michael Catanzaro from comment #0)
> r223691 "Turn recursive tail calls into loops" introduced the following
> warning when building WebKitGTK+ with GCC 7.2.1:
> 
> ../../Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp: In member function
> ‘bool JSC::DFG::ByteCodeParser::handleRecursiveTailCall(JSC::DFG::Node*,
> const JSC::CallLinkStatus&, int, JSC::VirtualRegister, int)’:
> ../../Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1483:83: warning:
> comparison is always false due to limited range of data type [-Wtype-limits]
>      } while (stackEntry->m_inlineCallFrame &&
> stackEntry->m_inlineCallFrame->kind == TailCall && (stackEntry =
> stackEntry->m_caller));
>                                               
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~
> 
> It's a bit surprising because InlineCallFrame::Kind has only eight possible
> values (including TailCall), and InlineCallFrame::kind is an unsigned
> bitfield three bits wide, which seems like it should be enough.

Oh wow. This should be
stackEntry->m_inlineCallFrame->kind == InlineCallFrame::TailCall I think

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171019/daefc6c5/attachment-0001.html>