[Webkit-unassigned] [Bug 176247] AX: Provide a way for Accessibility to cache the selection while retrieving rects for speak selection

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=176247

--- Comment #11 from Nan Wang <n_wang at apple.com> ---
(In reply to Ryosuke Niwa from comment #10)
> Comment on attachment 324241 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=324241&action=review
> 
> > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:2313
> > +- (void)_accessibilityStoreSelection:(BOOL)shouldStore
> > +{
> > +    _page->storeSelectionForAccessibility(shouldStore);
> > +}
> 
> Maybe it's better to add _accessibilityClearSelection instead of making this
> method take a bool
> It's kind of weird to say _accessibilityStoreSelection: FALSE.
> It sounds as if we're going to not store selection in the future instead of
> the call directly clearing what's already been stored.

Ok I will make another patch to address this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171019/73220f10/attachment.html>