[Webkit-unassigned] [Bug 176247] AX: Provide a way for Accessibility to cache the selection while retrieving rects for speak selection

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=176247

--- Comment #5 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 323958
  --> https://bugs.webkit.org/attachment.cgi?id=323958
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=323958&action=review

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:1893
> +void WebPage::cacheSelectionForAccessibility(bool shouldCache)

I don't think we should call this a "cache" since what we're doing here is to save the selection at the time of invocation.
A better name might be like storeSelectionForAccessibility or freezeSelectionForAccessibility.

There is an alternative approach which is to expose some sort of opaque object like WKWebViewSelection
and then add a new variant of getRectsForGranularityWithSelectionOffset which takes that opaque object
and computes the correct rect but that might be a bit of an overkill for this particular bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171019/79826bfb/attachment-0001.html>