[Webkit-unassigned] [Bug 178407] [GTK]BackingStoreBackendCairoImpl.h:23:10: fatal error: WebCore/HysteresisActivity.h

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=178407

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mcatanzaro at igalia.com

--- Comment #1 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Thanks for this bug report.

(In reply to s172262 from comment #0)
> I tried to build webkitgtk+ ver 2.18.0 with cairo on macos10.13.
> 
> >BackingStoreBackendCairoImpl.h:23:10: fatal error: WebCore/HysteresisActivity.h
> 
> Please change in
> Source/WebCore/platform/graphics/cairo/BackingStoreBackendCairoImpl.h at
> line 23.
> 
> - #include <WebCore/HysteresisActivity.h>
> + #include <WebCore/platform/HysteresisActivity.h>

WebKit coding style is to add the right include directories, so that full paths are not required. So the right fix is to add the right include path in some CMake file somewhere. Can't tell where without more of a build log to see where BackingStoreBackendCairoImpl.h is being included from. But it's very, very odd that WebCore/platform would not already be in the include path.

Anyway, HysteresisActivity has been moved to PAL in trunk, so it'll need to be fixed separately for 2.18. We're not going to fix it ourselves as we don't actually develop or support WebKitGTK+ on Mac, but we do consider community patches when posted following the guidance at https://webkit.org/contributing-code/#create-the-patch if you want to take a stab at it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171017/8c235481/attachment.html>