[Webkit-unassigned] [Bug 178076] [MSE][GStreamer] Insert parser elements in AppendPipeline when demuxing opus or Vorbis

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=178076

--- Comment #10 from Alicia Boya García <aboya at igalia.com> ---
Comment on attachment 323659
  --> https://bugs.webkit.org/attachment.cgi?id=323659
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=323659&action=review

>> Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp:736
>> +            mediaSample->presentationSize().width(), mediaSample->presentationSize().height());
> 
> Nit: You can have longer lines.

Next time you are checking whether the number and order of parameters is OK you'll be grateful for them to be separate lines.

>> Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp:1161
>> +    GST_DEBUG_BIN_TO_DOT_FILE_WITH_TS(GST_BIN(m_pipeline.get()), GST_DEBUG_GRAPH_SHOW_ALL, "pad-removed-after");
> 
> Nit: Why do we need so much pipeline dumping?

Should the unlinking fail or stop the player somehow we would like to know what happened in the append pipeline.

>> Source/WebCore/platform/graphics/gstreamer/mse/PlaybackPipeline.cpp:241
>> +        || !g_strcmp0(mediaType, "audio/x-vorbis"))
> 
> Nit: You can have longer lines here.

IMHO it's more readable this way: one line, one separate case where the condition is met.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171016/55db243c/attachment.html>