[Webkit-unassigned] [Bug 178080] [GTK][WPE] Fix review comments on WEBPImageDecoder

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=178080

--- Comment #2 from Miguel Gomez <magomez at igalia.com> ---
(In reply to Miguel Gomez from comment #1)
> Said, I was fixing your comments and I found something weird when replacing
> the usage of DecodingStatus::Partial. My idea was to set the buffer status
> to DecodingStatus::Decoding at the end of initFrameBuffer(), and then, set
> it to DecodingStatus::Complete if everything goes fine, or set it to
> DecodingStatus::Partial if there isn't enough data to decode the frame, but
> I found this inside ImageFrame.cpp:
> 
> void ImageFrame::setDecodingStatus(DecodingStatus decodingStatus)
> {
>     ASSERT(decodingStatus != DecodingStatus::Decoding);
>     m_decodingStatus = decodingStatus;
> }
> 
> DecodingStatus ImageFrame::decodingStatus() const
> {
>     ASSERT(m_decodingStatus != DecodingStatus::Decoding);
>     return m_decodingStatus;
> }
> 
> The asserts seem to imply that DecodingStatus::Decoding should not be used
> for some reason, but I don't get why. Is there any reason for this? Or are
> those asserts legacy code that could be removed? That code seems to be only
> used for the image decoders in Source/WebCore/platform/image-decoders/.

Said, please, could you give a look to this? Thanks in advance!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171016/90210758/attachment.html>