[Webkit-unassigned] [Bug 178274] We should wrap the removal of information from the tracker database in a transaction in DatabaseTracker::deleteOrigin()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=178274

--- Comment #3 from Brady Eidson <beidson at apple.com> ---
Comment on attachment 323719
  --> https://bugs.webkit.org/attachment.cgi?id=323719
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=323719&action=review

> Source/WebCore/Modules/webdatabase/DatabaseTracker.cpp:848
> +        auto rollbackTransaction = [this]() {
> +            if (!m_database.executeCommand("ROLLBACK TRANSACTION"))
> +                RELEASE_LOG_ERROR(DatabaseTracker, "Failed to rollback transaction after trying to remove origin from tracker");
> +        };

I think you should be able to use a SQLiteTransaction object here instead of this lambda and manually calling it on exit paths.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171013/552abe88/attachment-0001.html>