[Webkit-unassigned] [Bug 178076] [MSE][GStreamer] Insert parser elements in AppendPipeline when demuxing opus or Vorbis

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=178076

--- Comment #5 from Alicia Boya García <aboya at igalia.com> ---
Comment on attachment 323400
  --> https://bugs.webkit.org/attachment.cgi?id=323400
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=323400&action=review

>>> Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp:-1094
>>> -    // Must be done in the thread we were called from (usually streaming thread).
>> 
>> What happened to the black hole probe?
> 
> The condition in the `if` block was always false because by the time `pad-removed` is emitted the pad is already unlinked.
> I'm not completely sure about probes lifecycle but I think they are removed automatically with the pad when the pad refcount hits zero (which should be soon after the `pad-removed` handler finishes unless it's re-linked there).

I just checked it by adding a dummy constructor that prints to a file every time it's invoked: the probes are being destroyed correctly.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171013/6e71d326/attachment.html>