[Webkit-unassigned] [Bug 178160] [GStreamer][MSE] Trim space between codecs

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 11 12:59:50 PDT 2017


https://bugs.webkit.org/show_bug.cgi?id=178160

Manuel Rego Casasnovas <rego at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rego at igalia.com

--- Comment #13 from Manuel Rego Casasnovas <rego at igalia.com> ---
(In reply to Michael Catanzaro from comment #7)
> (In reply to Carlos Alberto Lopez Perez from comment #6)
> > What I'm unsure is about changing the expectation to contain FAIL lines. I
> > know some WebKit developers do that, but that always looked wrong to me.
> 
> We've basically decided to do that for WPT tests, yes, because that's what
> Youenn prefers and he's doing all of the work.

Yeah that's the agreed approach. The idea is that if you add also the FAIL messages
on the -expected result, you will notice when something changes.
If you just skip the test or mark a failure as a whole, you won't realize
when something changes from PASS to FAIL or the other way around.
So having the FAIL messages in the -expected file is useful as regression tests.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171011/7906719a/attachment.html>


More information about the webkit-unassigned mailing list