[Webkit-unassigned] [Bug 178136] Web Inspector: Make 3D objects selectable in Layers visualization

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=178136

Devin Rousso <webkit at devinrousso.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #323355|review?                     |review+
              Flags|                            |

--- Comment #5 from Devin Rousso <webkit at devinrousso.com> ---
Comment on attachment 323355
  --> https://bugs.webkit.org/attachment.cgi?id=323355
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=323355&action=review

r=me, with a few remaining NITs.

> Source/WebInspectorUI/UserInterface/Views/Layers3DContentView.js:117
> +        this._renderer.domElement.addEventListener("mousedown", this._canvasMouseDown.bind(this), false);

NIT: the `false` is unnecessary.

> Source/WebInspectorUI/UserInterface/Views/Layers3DContentView.js:281
> +WI.Layers3DContentView._unselectedColor = {

The word "unselect" is very weird.  Maybe just use "_color" and "_selectedColor"?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171011/8e27584e/attachment.html>