[Webkit-unassigned] [Bug 178139] Layers should be destroyed by RenderLayerModelObject

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=178139

Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #323328|review?                     |review+
              Flags|                            |

--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 323328
  --> https://bugs.webkit.org/attachment.cgi?id=323328
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=323328&action=review

> Source/WebCore/rendering/RenderObject.cpp:-1444
> -    // FIXME: Would like to do this in RenderBoxModelObject, but the timing is so complicated that this can't easily
> -    // be moved into RenderLayerModelObject::willBeDestroyed().
> -    // FIXME: Is this still true?
> -    if (hasLayer()) {
> -        setHasLayer(false);
> -        downcast<RenderLayerModelObject>(*this).destroyLayer();
> -    }
> -

Should RenderObject have ASSERT(!hasLayer()) somewhere late in its destruction to ensure that we didn't re-assign a layer after RenderLayerModelObject::destroyLayer() ran?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171010/af128b03/attachment.html>