[Webkit-unassigned] [Bug 178074] [GTK][MSE] Add dump of append pipeline

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=178074

Xabier Rodríguez Calvar <calvaris at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |calvaris at igalia.com
 Attachment #323164|review?, commit-queue?      |review+, commit-queue-
              Flags|                            |

--- Comment #3 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 323164
  --> https://bugs.webkit.org/attachment.cgi?id=323164
Patch

I agree with Enrique. This said, the patch is good enough and we can land it provided that you create a bug (and fix if if you can) to rework the way we subscribe and unsubscribe to signals in this and other pipelines.

First. we should subscribe with lambdas.

Second, we should unsubscribe with the by_data function instead of the by_func one. That way, as we always pass this as user_data, we'll always unsubscribe from stuff even when we haven't done it explicitly for all functions (and we won't need declared functions, lambdas will suffice).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171009/cc09939b/attachment.html>