[Webkit-unassigned] [Bug 177489] [iOS] Respect the "caret-color" CSS property when editing

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 6 15:23:50 PDT 2017


https://bugs.webkit.org/show_bug.cgi?id=177489

Tim Horton <thorton at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #323044|commit-queue+               |commit-queue-
              Flags|                            |

--- Comment #10 from Tim Horton <thorton at apple.com> ---
Comment on attachment 323044
  --> https://bugs.webkit.org/attachment.cgi?id=323044
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=323044&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:310
> +    CGColorSpaceRef colorSpace = CGColorSpaceCreateWithName(kCGColorSpaceGenericRGB);

This leaks.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:311
> +    CGColorRef cgInsertionPointColor = CGColorCreateCopyByMatchingToColorSpace(colorSpace, kCGRenderingIntentDefault, insertionPointColor.CGColor, NULL);

This leaks.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:312
> +    CGColorRef cgRedColor = CGColorCreateCopyByMatchingToColorSpace(colorSpace, kCGRenderingIntentDefault, redColor.CGColor, NULL);

This leaks.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171006/29598006/attachment-0001.html>


More information about the webkit-unassigned mailing list