[Webkit-unassigned] [Bug 177719] Either fold bmalloc into WTF or find a way to share code between then

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 2 15:48:32 PDT 2017


https://bugs.webkit.org/show_bug.cgi?id=177719

--- Comment #7 from Geoffrey Garen <ggaren at apple.com> ---
Reasons bmalloc is separate right now:

* bmalloc code should not call fastMalloc
* bmalloc code should not call system malloc
* non-bmalloc code should not use bmalloc code that is suboptimal because it avoids fastMalloc and system malloc
* the line between bmalloc and FastMalloc should be clear so we can experiment with other mallocs

Duplication of Platform.h macros is a slight bummer. But: 

(a) it's very little code, and honestly we've duplicated more than we need, and we can remove a lot;

(b) some things need duplication because they're truly different, like ASSERT, which in WTF's variant calls malloc, which is not OK;

(c) if we care to, we can just move these macros into bmalloc and include them from WTF.

Duplication of WordLock is a slight bummer. But, again, the behavior really needs to change to not call malloc. Including WordLock as is in bmalloc is not right, so it's a good thing that doing so was hard.

I'm not sure what's up with duplication of Gigacage code. Why can't the code be exported from bmalloc into WTF?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171002/ac6f32e0/attachment.html>


More information about the webkit-unassigned mailing list