[Webkit-unassigned] [Bug 167956] [Harfbuzz] Implement ComplexTextController on top of HarfBuzz

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=167956

--- Comment #13 from Sam Weinig <sam at webkit.org> ---
(In reply to Carlos Garcia Campos from comment #11)
> (In reply to Sam Weinig from comment #10)
> > (In reply to Carlos Garcia Campos from comment #7)
> > > (In reply to Sam Weinig from comment #6)
> > > > For all the places where we now have PLATFORM(COCOA) || USE(HARFBUZZ), is
> > > > there more explicit predicate we could use? HAVE(...) for instance?
> > > 
> > > I don't think so, those cases are the implementations of
> > > ComplexTextController. After this change there are 2 implementations
> > > ComplexTextControllerCoreText.mm and ComplexTextControllerHarfBuzz.cpp, only
> > > ComplexTextControllerDirectWrite.cpp would be missing. So, we could use
> > > something like if !PLATFORM(WIN) maybe, but that would be more confusing, I
> > > think.
> > 
> > So it USE(COMPLEX_TEXT_CONTROLLER) + NOT WINDOWS. Any idea what makes the
> > DirectWrite implementation different that it shouldn't use these functions?
> 
> There's a WIP patch in bug #167954

Ok.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171002/2fc67805/attachment.html>