[Webkit-unassigned] [Bug 180159] New: commit-queue gets set as author when it should be able to identify a user

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 29 12:24:51 PST 2017


            Bug ID: 180159
           Summary: commit-queue gets set as author when it should be able
                    to identify a user
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: lforschler at apple.com
                CC: lforschler at apple.com

smfr let me know that we have many instances where the Author: is being set to commit-queue at webkit.org, rather than the real author.

<smfr> i see too many commits like https://trac.webkit.org/changeset/225278/webkit where the author is commit-queue rather than the real person
<smfr>  but sometimes it works: https://trac.webkit.org/changeset/225277/webkit
<smfr>  bad: https://trac.webkit.org/changeset/225279/webkit
<smfr>  alex has the right emails in contributors.json

I'm not sure where this lives, but a quick search says it should all be in webkitpy
commit.py but it starts with username = None
commands/analyzechangelog.py might be promising

I also see a regex in there: 
date_line_regexp = r'^(?P<date>\d{4}-\d{2}-\d{2})\s+(?P<authors>(?P<name>[^<]+?)\s+<(?P<email>[^<>]+)>.*?)$'

however, for the failing one by Antoine, the regex parses correctly.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171129/c0c75674/attachment.html>

More information about the webkit-unassigned mailing list