[Webkit-unassigned] [Bug 180140] Add StyleBench

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=180140

Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #327854|review?                     |review+
              Flags|                            |

--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 327854
  --> https://bugs.webkit.org/attachment.cgi?id=327854
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327854&action=review

> PerformanceTests/StyleBench/InteractiveRunner.html:21
> +function formatTestName(suiteName, testName) {

Opening function parens on new line please (everywhere)

> PerformanceTests/StyleBench/InteractiveRunner.html:42
> +        label.appendChild(document.createTextNode(formatTestName(suite.name)));

or just set textContent?

> PerformanceTests/StyleBench/InteractiveRunner.html:53
> +            anchor.appendChild(document.createTextNode(formatTestName(suite.name, test.name)));

Set textContent?

> PerformanceTests/StyleBench/resources/style-bench.js:26
> +function nextAnimationFrame() { return new Promise((resolve) => requestAnimationFrame(resolve)); }

No reason to have this all on one line.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171129/8d029973/attachment.html>