[Webkit-unassigned] [Bug 180080] [EME][GStreamer] Add the full-sample encryption support in the GStreamer ClearKey decryptor

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=180080

--- Comment #9 from Yacine Bandou <bandou.yacine at gmail.com> ---
(In reply to Xabier Rodríguez Calvar from comment #6)
> (In reply to Yacine Bandou from comment #4)
> > > gboolean -> bool
> > > 
> > It's not my code, it was already here
> 
> I happens a lot of times to me too. I'm not in favor of changing things when
> they are wrong if it's just a style issue just for the style itself but if I
> have to change the line, I prefer to correct the style too.
> 
> > I think there is a misunderstanding during the patch review
> > 
> > Here is the diff by ignoring the space change:
> 
> Oh, I see. But you're modifying those lines anyway and they will be
> reflected like your change in the diff and as I say before, better to
> correct the things that we can when we touch those lines.

understood and I agree.

But it depends on the reviewer, there are who do not like to change the existing code just for the style.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171129/6578009c/attachment-0001.html>