[Webkit-unassigned] [Bug 180080] [EME][GStreamer] Add the full-sample encryption support in the GStreamer ClearKey decryptor

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 29 04:54:58 PST 2017


--- Comment #6 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
(In reply to Yacine Bandou from comment #4)
> > gboolean -> bool
> > 
> It's not my code, it was already here

I happens a lot of times to me too. I'm not in favor of changing things when they are wrong if it's just a style issue just for the style itself but if I have to change the line, I prefer to correct the style too.

> I think there is a misunderstanding during the patch review
> Here is the diff by ignoring the space change:

Oh, I see. But you're modifying those lines anyway and they will be reflected like your change in the diff and as I say before, better to correct the things that we can when we touch those lines.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171129/5c60b0ed/attachment.html>

More information about the webkit-unassigned mailing list