[Webkit-unassigned] [Bug 179714] [Touch Bar Web API] Object representing Touch Bar Menu to send between Web and UI Processes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 28 17:20:15 PST 2017


--- Comment #33 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 327780
  --> https://bugs.webkit.org/attachment.cgi?id=327780

View in context: https://bugs.webkit.org/attachment.cgi?id=327780&action=review

> Source/WebKit/Shared/TouchBarMenuData.h:48
> +    Vector<TouchBarMenuItemData> items() { return m_items; }

This seems like this should be const Vector<TouchBarMenuItemData>&.

> Source/WebKit/Shared/TouchBarMenuItemData.h:59
> +    String customizationLabel;

The customizationLabel is the text that's shown when customizing the items on the touch bar via View > Customize Touch Bar…. It looks like this is set to the value of the menu item's title attribute, however — perhaps this could just be label?

> Source/WebKit/Shared/TouchBarMenuItemData.h:60
> +    float priority { 0.0 };

I would prefer to pare down this list of member variables, so that we only add what we'll need in this patch and the next.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171129/0837d3a7/attachment-0001.html>

More information about the webkit-unassigned mailing list