[Webkit-unassigned] [Bug 179814] [Win] forwarding headers should not be copies

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=179814

--- Comment #35 from Don Olmstead <don.olmstead at sony.com> ---
(In reply to Mark Salisbury from comment #34)
> (In reply to Alex Christensen from comment #32)
> > (In reply to Don Olmstead from comment #20)
> > > It’s my understanding that the copy is present in ALL Apple ports. I think
> > > it’s better for the project as a whole for everyone to move to copying the
> > > headers for consistency.
> > 
> > I agree.
> > 
> > (In reply to Michael Catanzaro from comment #25)
> > > Copying headers is fundamentally incompatible with #pragma once.
> > 
> > This is not true if we include directories well.  For example, when building
> > WTF we should include the Source/WTF directory and not the directory
> > containing the copies and when building everything else we should include
> > the directory containing the copies.  When building JSC we should include
> > Source/JavaScriptCore and not the directory containing the copies and when
> > building everything else we should include the directory containing the
> > copies.  Etc.
> 
> Sounds like that would work.  I do think having copies of .h files in
> different places is kludgy.
> 
> As long as the discussion is around what's ideal, wouldn't it be better not
> to need forwarding headers at all?
> 
> What if all #includes were relative to either the top level source directory
> or to the derived sources directory?  This might even make compiles a little
> bit faster since they wouldn't have to search so many directories.  It'd
> make build output files smaller ;)  It would make code more readable.
> 
> What problems would arise from this?

https://bugs.webkit.org/show_bug.cgi?id=180063#c5

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171129/6686c86d/attachment.html>