[Webkit-unassigned] [Bug 179714] [Touch Bar Web API] Object representing Touch Bar Menu to send between Web and UI Processes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=179714

--- Comment #23 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 327211
  --> https://bugs.webkit.org/attachment.cgi?id=327211
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327211&action=review

>> Source/WebCore/html/HTMLMenuElement.cpp:43
>> +#if PLATFORM(COCOA)
> 
> I don't think we want to guard this behind PLATFORM(COCOA).
> There is no reason these code need to be COCOA specific beyond menuItemElementEnabled() check.
> In general, we should try avoiding adding if PLATFORM(~) in WebCore
> because it increases the cognitive stress for people reading the code.
> It's much simpler to see the code as a runtime enabled feature.

I think making just the touch-bar-specific bits in WebKit fall under PLATFORM(MAC) or PLATFORM(COCOA) is sensible. I agree, the menu/menuitem element code in WebCore should definitely be platform agnostic.

>> Source/WebKit/Shared/TouchBarMenuData.h:46
>> +    WEBCORE_EXPORT ~TouchBarMenuData();
> 
> As I stated in the previous patch, I don't think there is any need to define an explicit destructor.
> Inlining it here should work just fine.

Also, I don't think we need to export this destructor.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171127/eaa5ff33/attachment-0001.html>