[Webkit-unassigned] [Bug 179982] Style resolution spin due to calc() values in animations always comparing inequal (seen on arstechnica.com)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=179982

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darin at apple.com
 Attachment #327538|review?                     |review+
              Flags|                            |

--- Comment #6 from Darin Adler <darin at apple.com> ---
Comment on attachment 327538
  --> https://bugs.webkit.org/attachment.cgi?id=327538
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327538&action=review

> Source/WebCore/platform/CalculationValue.cpp:130
> +    // Maybe Vectors of unique_ptrs should always do deep compare?

VectorTypeOperations exists so that we can do that kind of thing. It looks like we never specialized VectorTypeOperations, though, so I’m not entirely sure why we have it!

> Source/WebCore/platform/CalculationValue.cpp:134
> +        if (!(*a.children()[i] == *b.children()[i]))

Could use a != b instead of !(a == b)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171124/e8b4fbe7/attachment-0001.html>