[Webkit-unassigned] [Bug 179989] REGRESSION(r225098): [GTK] Some features have changed of value (13 new failures)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 24 04:23:07 PST 2017


--- Comment #6 from Michael Catanzaro <mcatanzaro at igalia.com> ---
The tests were passing before because the bots previously used the features defined in FeatureList.pm. Your diff shows that FeatureList.pm was enabling many unsupported features -- features that are both PRIVATE and OFF in WebKitFeatures.cmake and/or OptionsGTK.cmake -- and so tests that depended on those features were passing. But nobody is going to notice the difference except for our test bots and developers using build-webkit.

This is exactly why we wanted to remove the list of feature defaults from FeatureList.pm. Nobody was even attempting to keep it in sync with WebKitFeatures.cmake.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171124/f0d6ec5a/attachment.html>

More information about the webkit-unassigned mailing list