[Webkit-unassigned] [Bug 179899] Allow for more efficient use of GenericTypedArrayView

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=179899

--- Comment #11 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
(In reply to Darin Adler from comment #9)
> Comment on attachment 327378 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=327378&action=review
> 
> > Source/JavaScriptCore/runtime/ArrayBufferView.h:122
> > +    inline bool setRangeImpl(const char* data, size_t dataByteLength, unsigned byteOffset, unsigned bufferByteLength);
> > +    inline bool getRangeImpl(char* destination, size_t dataByteLength, unsigned byteOffset, unsigned bufferByteLength);
> 
> The "inline" on all these functions are not needed.

Without them I get duplicate symbol errors at link time.

> Should these be void* instead of char*? Or maybe uint8_t*?

void*, yes. Will fix in a followup.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171123/67ebfda7/attachment.html>