[Webkit-unassigned] [Bug 179899] Allow for more efficient use of GenericTypedArrayView

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=179899

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darin at apple.com

--- Comment #9 from Darin Adler <darin at apple.com> ---
Comment on attachment 327378
  --> https://bugs.webkit.org/attachment.cgi?id=327378
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327378&action=review

> Source/JavaScriptCore/runtime/ArrayBufferView.h:122
> +    inline bool setRangeImpl(const char* data, size_t dataByteLength, unsigned byteOffset, unsigned bufferByteLength);
> +    inline bool getRangeImpl(char* destination, size_t dataByteLength, unsigned byteOffset, unsigned bufferByteLength);

The "inline" on all these functions are not needed.

Should these be void* instead of char*? Or maybe uint8_t*?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171122/91156a82/attachment-0001.html>