[Webkit-unassigned] [Bug 179504] [PAL] Remove FileSystem's dependency on WebCoreNSStringExtras

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=179504

--- Comment #13 from Christopher Reid <christopher.reid at am.sony.com> ---
(In reply to Darin Adler from comment #12)
> Comment on attachment 327374 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=327374&action=review
> 
> Great job. I have a few comments about how to do this even better.
> 
> > Source/WebCore/loader/mac/LoaderNSURLExtras.h:29
> > +#pragma once
> 
> If every include of a header uses #import rather than #include, then there
> is no need for #pragma once. Objective-C compilers all have #import, this is
> an Objective-C header, and we should always use #import for it. Thus there
> is no need to add #pragma once.

Ah, I am new to Objective-C but that's interesting to see that this is handled automatically by its #import directive.

Thanks for the feedback, I'll make your suggested changes.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171121/7ba38313/attachment-0001.html>