[Webkit-unassigned] [Bug 179926] New: std::tuple is used in WTF without including tuple

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=179926

            Bug ID: 179926
           Summary: std::tuple is used in WTF without including tuple
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Web Template Framework
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: stephan.szabo at sony.com

There are some cases where a few WTF headers that use tuple without including <tuple> (HashFunctions.h, PrintStream.h, Signals.h) can cause compilation failures on toolchains where tuple isn't being already defined (for example via include from another previously included STL header) and don't delay templates like MSVC.

For Signals.h, it appears that the only place in Signals.cpp the additional <tuple> include would work in break the header include order (it would have to be before the include of Signals.h itself). For PrintStream.h, it might be possible to find another location, although the first specific error we see is in SlotVisitor.cpp and adding in the accepted header include position in either that file or SlotVisitor.h did not fix the error. For HashFunctions (or at least HashTraits that uses it), there appeared to be failures in WTF, LLIntOffsetsExtractor, and JavaScriptCore and test* apps for failures to find make_tuple via paths including it from heap/Weak.h and text/CString.h across at least 5 of the JSC unified sources.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171121/ed49a8be/attachment-0001.html>