[Webkit-unassigned] [Bug 179504] [PAL] Remove FileSystem's dependency on WebCoreNSStringExtras

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 20 13:58:41 PST 2017


https://bugs.webkit.org/show_bug.cgi?id=179504

Build Bot <ews at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ews at webkit.org

--- Comment #9 from Build Bot <ews at webkit.org> ---
Attachment 327372 did not pass style-queue:


ERROR: Source/WebKitLegacy/mac/Misc/WebNSBundleExtras.mm:29:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Source/WebCore/loader/mac/LoaderNSURLExtras.mm:105:  Missing space after ,  [whitespace/comma] [3]
ERROR: Source/WebCore/loader/mac/LoaderNSURLExtras.mm:106:  One line control clauses should not use braces.  [whitespace/braces] [4]
ERROR: Source/WebKitLegacy/mac/Misc/WebKitNSStringExtras.mm:177:  Missing spaces around |  [whitespace/operators] [3]
ERROR: Source/WebCore/loader/mac/LoaderNSURLExtras.h:38:  The parameter name "string" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 5 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171120/74c88cab/attachment.html>


More information about the webkit-unassigned mailing list