[Webkit-unassigned] [Bug 179864] New: filter-build-webkit filters out useful compiler error lines

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=179864

            Bug ID: 179864
           Summary: filter-build-webkit filters out useful compiler error
                    lines
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: simon.fraser at apple.com
                CC: lforschler at apple.com

filter-build-webkit turns this:

In file included from /Volumes/DataSSD/Development/apple/webkit/OpenSource/WebKitBuild/Release/DerivedSources/WebCore/unified-sources/UnifiedSource356.cpp:1:
/Volumes/DataSSD/Development/apple/webkit/OpenSource/Source/WebCore/platform/graphics/filters/FETurbulence.cpp:330:9: error: non-constant-expression cannot be narrowed from type 'int' to 'float' in initializer list [-Wc++11-narrowing]
        std::max(0, std::min(static_cast<int>(floatComponents.components[0] * 255), 255)),
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Volumes/DataSSD/Development/apple/webkit/OpenSource/Source/WebCore/platform/graphics/filters/FETurbulence.cpp:330:9: note: insert an explicit cast to silence this issue
        std::max(0, std::min(static_cast<int>(floatComponents.components[0] * 255), 255)),
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        static_cast<float>(                                                              )


into this:

In file included from /Volumes/DataSSD/Development/apple/webkit/OpenSource/WebKitBuild/Release/DerivedSources/WebCore/unified-sources/UnifiedSource356.cpp:1:
/Volumes/DataSSD/Development/apple/webkit/OpenSource/Source/WebCore/platform/graphics/filters/FETurbulence.cpp:330:9: error: non-constant-expression cannot be narrowed from type 'int' to 'float' in initializer list [-Wc++11-narrowing]
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Volumes/DataSSD/Development/apple/webkit/OpenSource/Source/WebCore/platform/graphics/filters/FETurbulence.cpp:330:9: note: insert an explicit cast to silence this issue
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        static_cast<float>(                                                              )

which hides some detail needed to fix bugs.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171118/ee541efa/attachment.html>