[Webkit-unassigned] [Bug 179496] AX: AOM: Implement boolean type properties

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=179496

--- Comment #15 from Nan Wang <n_wang at apple.com> ---
(In reply to Ryosuke Niwa from comment #14)
> Comment on attachment 327237 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=327237&action=review
> 
> > Source/WebCore/accessibility/AXObjectCache.cpp:2885
> > +            std::optional<bool> hiddenValue = AccessibleNode::effectiveBoolValueForElement(downcast<Element>(*testNode), AXPropertyName::Hidden);
> 
> Use auto in these cases.
> 
> > Source/WebCore/accessibility/AccessibilityARIAGrid.cpp:85
> > +    std::optional<bool> multiSelectable = boolValueForProperty(AXPropertyName::Multiselectable);
> 
> Use auto.
> 
> > Source/WebCore/accessibility/AccessibilityNodeObject.cpp:628
> > +        if (std::optional<bool> disabled = object->boolValueForProperty(AXPropertyName::Disabled)) {
> 
> Use auto.
> 
> > Source/WebCore/accessibility/AccessibilityNodeObject.cpp:707
> > +    std::optional<bool> multiSelectable = boolValueForProperty(AXPropertyName::Multiselectable);
> 
> Use auto.

Ok I will update these in https://bugs.webkit.org/show_bug.cgi?id=179497

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171118/548dffb7/attachment.html>