[Webkit-unassigned] [Bug 179814] [Win] forwarding headers should not be copies

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=179814

--- Comment #28 from Mark Salisbury <mark.salisbury at hp.com> ---
(In reply to Mark Salisbury from comment #27)

> 2) Figure out why my Win WPE build has a different header search path order
> than WinCairo.  The forwarding header include path has to come AFTER the
> include search path that triggers finding the real .h file.  In practice I
> think that means the forwarding header path should come last.

It doesn't have a different search order.  WinCairo has ForwardingHeaders first too.  This wasn't a problem when the files were copies.

I still believe the same options apply though:

1) Make the forwarding header paths full paths
2) Move fowarding header include path to the end of the includes paths

I like #1 better.

For the curious, here's the example I included in e-mail about how the same header file gets included twice.  There were many others:

First source file including ArrayBufferSharingMode.h:

1>Note: including file: D:\git\webkit-org\Source\WebCore\css/DOMMatrix.cpp
1>Note: including file:  D:\git\webkit-org\Source\WebCore\config.h
1>Note: including file:  d:\git\webkit-org\source\webcore\css\DOMMatrix.h
1>Note: including file:   d:\git\webkit-org\source\webcore\css\DOMMatrixReadOnly.h
1>Note: including file:    d:\git\webkit-org\source\webcore\css\DOMMatrixInit.h
1>Note: including file:     d:\git\webkit-org\source\webcore\css\DOMMatrix2DInit.h
1>Note: including file:    D:\git\webkit-org\Source\WebCore\bindings\js\ScriptWrappable.h
1>Note: including file:     D:\git\webkit-org\Source\JavaScriptCore\heap/Weak.h
1>Note: including file:    D:\git\webkit-org\Source\WebCore\platform\graphics\transforms\TransformationMatrix.h
1>Note: including file:     D:\git\webkit-org\Source\WebCore\platform\graphics\FloatPoint.h
1>Note: including file:      d:\git\webkit-org\source\webcore\platform\graphics\FloatSize.h
1>Note: including file:       d:\git\webkit-org\source\webcore\platform\graphics\IntPoint.h
1>Note: including file:        d:\git\webkit-org\source\webcore\platform\graphics\IntSize.h
1>Note: including file:     D:\git\webkit-org\Source\WebCore\platform\graphics\FloatPoint3D.h
1>Note: including file:    D:\git\webkit-org\Source\JavaScriptCore\runtime/Float32Array.h
1>Note: including file:     d:\git\webkit-org\source\javascriptcore\runtime\TypedArrays.h
1>Note: including file:      d:\git\webkit-org\source\javascriptcore\runtime\GenericTypedArrayView.h
1>Note: including file:       d:\git\webkit-org\source\javascriptcore\runtime\ArrayBuffer.h
1>Note: including file:        d:\git\webkit-org\source\javascriptcore\runtime\ArrayBufferSharingMode.h

Second source file including ArrayBufferSharingMode.h:

1>Note: including file: D:\git\webkit-org\Source\WebCore\css/DOMMatrixReadOnly.cpp
1>Note: including file:  D:\git\webkit-org\Source\WebCore\config.h
1>Note: including file:  d:\git\webkit-org\source\webcore\css\CSSToLengthConversionData.h
1>Note: including file:  D:\git\webkit-org\Source\WebCore\dom\DOMPoint.h
1>Note: including file:   d:\git\webkit-org\source\webcore\dom\DOMPointReadOnly.h
1>Note: including file:    d:\git\webkit-org\source\webcore\dom\DOMPointInit.h
1>Note: including file:  d:\git\webkit-org\source\webcore\css\TransformFunctions.h
1>Note: including file:   D:\git\webkit-org\Source\WebCore\platform\graphics\transforms\TransformOperations.h
1>Note: including file:    D:\git\webkit-org\Source\WebCore\platform\graphics\LayoutSize.h
1>Note: including file:    d:\git\webkit-org\source\webcore\platform\graphics\transforms\TransformOperation.h
1>Note: including file:  D:\git\webkit-org\WebKitBuild\Debug\DerivedSources\ForwardingHeaders\JavaScriptCore/GenericTypedArrayViewInlines.h
1>Note: including file:   d:\git\webkit-org\webkitbuild\debug\derivedsources\forwardingheaders\javascriptcore\GenericTypedArrayView.h
1>Note: including file:    d:\git\webkit-org\webkitbuild\debug\derivedsources\forwardingheaders\javascriptcore\ArrayBuffer.h
1>Note: including file:     d:\git\webkit-org\webkitbuild\debug\derivedsources\forwardingheaders\javascriptcore\ArrayBufferSharingMode.h

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171118/e5e3d6be/attachment-0001.html>