[Webkit-unassigned] [Bug 179496] AX: AOM: Implement boolean type properties

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=179496

--- Comment #11 from Nan Wang <n_wang at apple.com> ---
Comment on attachment 327237
  --> https://bugs.webkit.org/attachment.cgi?id=327237
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327237&action=review

>> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:3200
>> +        return [NSNumber numberWithBool:m_object->ariaIsMultiline()];
> 
> there must be iOS changes required too right?

I only added this to support test and the test is only available on Mac. 
I think we might need to expose more stuff in future to make this test cross platform. Right now I just used the macOS attribute names to test most properties.

>> LayoutTests/accessibility/mac/AOM-bool-properties.html:144
>> +    function testRequired() {
> 
> missing tests for 
> Atomic
> Busy

Atomic is covered in testClearBooleanProperty().
and there is a testBusy();

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171117/234e0cc2/attachment.html>