[Webkit-unassigned] [Bug 179496] AX: AOM: Implement boolean type properties

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=179496

--- Comment #3 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 327217
  --> https://bugs.webkit.org/attachment.cgi?id=327217
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327217&action=review

> Source/WebCore/accessibility/AXObjectCache.cpp:120
> +static const Seconds accessibilityFocusAXModalNodeNotificationInterval { 50_ms };

I think the AX might be redundant, since we're already in the AX code base. I think that can just be removed
that comment applies to everything below here too

> Source/WebCore/accessibility/AccessibilityObject.cpp:2166
> +    return std::nullopt;

should we just return false here instead of using optionals?
do we check null opt anywhere?

> Source/WebCore/accessibility/AccessibleNode.cpp:124
> +    default:

we should remove the default case so we know everything is handled always

> Source/WebCore/accessibility/AccessibleNode.cpp:127
> +}

then we return false here

> LayoutTests/accessibility/mac/AOM-bool-properties.html:59
> +        shouldBeNull("node.accessibleNode.atomic");

is this expected behavior? or should it return false?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20171117/c57914fc/attachment.html>